contracts #4
Merged
contracts #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhABC
reviewed
Jun 27, 2023
src/tokens/ERC1155/ERC1155Sale.sol
Outdated
| * @param _tokenIds Token IDs to mint. | ||
| * @param _amounts Amounts of tokens to mint. | ||
| */ | ||
| function _payForActiveMint(uint256[] memory _tokenIds, uint256[] memory _amounts) private { |
There was a problem hiding this comment.
We probably need the ability to add a mint limit per token ID. Should be optional, i.e. if limit is 0, then there is no limit, otherwise it's the limit specified.
Contributor
Author
There was a problem hiding this comment.
Is that per transaction / wallet? There is a supply cap limit per token already
Closed
make sure metadata output is included in forge build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current PR state: This is missing the ERC-1155 Packed implementation. I believe it will be trivial to add and would like to have the current contract reviewed/audited first to reduce any re-work.
Depends on 0xsequence/erc-1155#100